Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sem-speed-test program creates tasks with zero stack size #272

Closed
jphickey opened this issue Oct 23, 2019 · 0 comments · Fixed by #281
Closed

sem-speed-test program creates tasks with zero stack size #272

jphickey opened this issue Oct 23, 2019 · 0 comments · Fixed by #281
Assignees
@jphickey
Labels
bug
Milestone
Bootes

Comments

@jphickey
Copy link
Contributor

Describe the bug
For RTEMS and POSIX this is not an issue because these implementations will just use a minimum stack size, but VxWorks actually creates the task with a very small stack. The worker tasks are then likely to overrun the stack, causing undefined behavior.

To Reproduce
Execute sem-speed-test on the MPC750 test platform
Observe inconsistent behavior during/after test (sometimes it completes OK, sometimes errors, occasionally even a reboot).

Expected behavior
The test should complete successfully.

System observed on:
MCP750, VxWorks 6.9

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Oct 23, 2019
jphickey added a commit that referenced this issue Oct 23, 2019
@jphickey
Fix #272: use 4K stack for sem-speed-test tasks
00a1115 
On VxWorks, no minimum stack size is implemented,
and the implementation will create tasks with an
extremely small stack if "0" is passed in.

This causes the worker tasks to overrun the stack
on Vxworks, triggering undefined/inconsistent
behavior.
@jphickey jphickey mentioned this issue Oct 23, 2019
Merged
@skliper skliper added the bug label Oct 30, 2019
@skliper skliper added this to the 5.1.0 milestone Oct 30, 2019
skliper pushed a commit that referenced this issue Oct 31, 2019
@jphickey @skliper
Fix #272: use 4K stack for sem-speed-test tasks
8310170 
On VxWorks, no minimum stack size is implemented,
and the implementation will create tasks with an
extremely small stack if "0" is passed in.

This causes the worker tasks to overrun the stack
on Vxworks, triggering undefined/inconsistent
behavior.
skliper added a commit that referenced this issue Oct 31, 2019
@skliper
CCB 20191030: Merge #257 #276 #277 #278
58d4d74 
Fixes #271 #272 #273 #274
Code reviewed and approved at 20191030 CCB
@skliper skliper mentioned this issue Oct 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
bug
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Integration Candidate 20191030 nasa/osal
2 participants
@jphickey @skliper