Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider skipping/truncating symbol if name to long #1270

Closed
dmknutsen opened this issue Jul 15, 2022 · 0 comments
Closed

Consider skipping/truncating symbol if name to long #1270

dmknutsen opened this issue Jul 15, 2022 · 0 comments
Assignees
Milestone

Comments

@dmknutsen
Copy link
Contributor

os-impl-sytab::OS_SymTableIteratro_Impl will exit a symbol table dump if it detects a symbol name that violates the maximum defined length. This results in an inability to dump the symbol map if a symbol does violate the max length. Consider skipping the symbol or truncating it + notify user via entry in dump file.

if (memchr(name, 0, OS_MAX_SYM_LEN) == NULL)
{
    OS_DEBUG("%s(): symbol name too long\n", __func__);
    state->StatusCode = OS_ERR_NAME_TOO_LONG;
    return (false);
}

path to file: osal/src/os/vxworks/src/os-impl-sytab.c

Requester Info
Dan Knutsen
NASA Goddard

@havencarlson havencarlson self-assigned this Oct 19, 2022
havencarlson added a commit to havencarlson/osal that referenced this issue Nov 2, 2022
havencarlson added a commit to havencarlson/osal that referenced this issue Nov 15, 2022
dmknutsen added a commit to dmknutsen/osal that referenced this issue Nov 16, 2022
dzbaker added a commit that referenced this issue Nov 17, 2022
Fix #1270: Truncate symbol name if > OS_MAX_SYM_LEN
@chillfig chillfig added this to the Draco milestone Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants