-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nos3#464 eps checkout #474
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevincbruce
requested review from
jlucas9,
szemerick,
msuder,
Donnie-Ice,
rjbrown2,
dccutrig,
dacarter22,
zlynch2 and
Isgaroth-the-Green
January 21, 2025 22:52
Isgaroth-the-Green
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to run the checkout and everything seemed to work as it should.
rjbrown2
approved these changes
Jan 22, 2025
dacarter22
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built and ran successfully and confirmed functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a checkout application for the generic_eps component. Have verified the checkout launches and can be commanded in the newest push. The branch is set up so that the top level files should be set up as normal in dev, and thus need to be modified to work the checkout. The old checkout was based off our old sample format before we changed our file structure from support to standalone, and had a few other errors (passing addresses instead of values and vice versa, no nos_link, expecting 1 and 3 tokens opposed to 0 and 2 for hk and switch (respectively), etc) which have been amended. It should also take hex inputs for values by using strtol, so that it matches its help.
The only concern I still see:
Steps:
Enable EPS in the NOS3 minimal config, switch to using the minimal config in the top level no3 mission config, and uncomment the Electrical Power System (EPS) part of checkout.sh in scripts.
make clean
make debug
cd components/generic_css/fsw/standalone/build
(mkdir build in the standalone directory if needed, then cd build)
make clean (if build directory already exists)
cmake .. -DTGTNAME=cpu1
make
exit
make clean
make
make checkout
The following submodule PRs must be merged and updated first:
nasa-itc/generic_eps#11
Closes #464