Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasa/nos3#352] Update CryptoLib to 1.3.2 #401

Merged
merged 17 commits into from
Jan 29, 2025

Conversation

Donnie-Ice
Copy link
Contributor

@Donnie-Ice Donnie-Ice commented Oct 30, 2024

To test: Send CFS_RADIO TO_ENABLE_OUTPUT, data should start flowing

@Donnie-Ice Donnie-Ice self-assigned this Oct 30, 2024
@Donnie-Ice Donnie-Ice linked an issue Oct 30, 2024 that may be closed by this pull request
@Donnie-Ice
Copy link
Contributor Author

Local build issue currently:
image

@jlucas9
Copy link
Contributor

jlucas9 commented Oct 30, 2024

Getting this locally for me as well:

-- Building Dynamic App: cryptolib targets=cpu1
CMake Error at /home/jstar/git/nos3/n4/components/cryptolib/src/CMakeLists.txt:134 (install):
  install TARGETS RUNTIME_DEPENDENCIES is not supported when cross-compiling.

@jlucas9 jlucas9 changed the title [nasa/nos3#352] Update CryptoLib to 1.3.1 WIP: [nasa/nos3#352] Update CryptoLib to 1.3.1 Nov 4, 2024
@kevincbruce kevincbruce changed the title WIP: [nasa/nos3#352] Update CryptoLib to 1.3.1 WIP: [nasa/nos3#352] Update CryptoLib to 1.3.2 Dec 16, 2024
@rjbrown2
Copy link
Member

Do we need to do something like this:

if(NOT CMAKE_CROSSCOMPILING)
install(TARGETS cryptolib
RUNTIME_DEPENDENCIES
# Other dependencies here
)
else()
install(TARGETS cryptolib)
endif()

@Donnie-Ice
Copy link
Contributor Author

Update: Currently trying to update TO for TM decryption/framing before release.

@Donnie-Ice Donnie-Ice changed the title WIP: [nasa/nos3#352] Update CryptoLib to 1.3.2 [nasa/nos3#352] Update CryptoLib to 1.3.2 Jan 24, 2025
Copy link
Contributor

@kevincbruce kevincbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Radio Interface appears to work with CryptoLib, so approving!

@jlucas9
Copy link
Contributor

jlucas9 commented Jan 27, 2025

@rjbrown2 / @Donnie-Ice do you all have the changes to the deployment repo for the new script pushed up too?

@jlucas9
Copy link
Contributor

jlucas9 commented Jan 27, 2025

How do I test encrypted commands?

@Donnie-Ice
Copy link
Contributor Author

Donnie-Ice commented Jan 27, 2025

@rjbrown2 / @Donnie-Ice do you all have the changes to the deployment repo for the new script pushed up too?

The only thing changed from the deployment repo is the docker image tag, which is pushed to docker cloud.

How do I test encrypted commands?

In the cryptolib window, type tc, then type vcid 2. Commands being sent should now be encrypted.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev@3de9a90). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #401   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?       1           
  Lines          ?       2           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?       2           
  Partials       ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jlucas9 jlucas9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well for me swapping between VCID 1 (default / clear) and VCID 2 (aes-gcm encrypted).

image

Can we squash this one with the merge?

@Donnie-Ice Donnie-Ice requested a review from dccutrig January 28, 2025 21:38
Copy link

@dacarter22 dacarter22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Encrypted messages seems to be working on my end
image

@Donnie-Ice Donnie-Ice merged commit 1b68c6f into dev Jan 29, 2025
3 checks passed
@Donnie-Ice Donnie-Ice deleted the 352-nos3-update-cryptolib-131 branch January 29, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NOS3 Update CryptoLib 1.3.2
7 participants