Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 202 - Categorize counts of differences (including attributes) in a summary #276

Conversation

danielfromearth
Copy link
Collaborator

@danielfromearth danielfromearth commented Dec 12, 2024

GitHub Issue: #202

Description

Expand summary at end of comparison report to include counting and display of attribute differences (total number and which types).

Local test steps

Revised golden files, and passed unit tests.

PR Acceptance Checklist

  • Unit tests added/updated and passing.
  • [n/a] Integration testing
  • CHANGELOG.md updated
  • Documentation updated (if needed).

📚 Documentation preview 📚: https://ncompare--276.org.readthedocs.build/en/276/

@danielfromearth danielfromearth changed the base branch from main to develop December 12, 2024 19:20
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 92.75362% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.62%. Comparing base (e25792b) to head (7a34e35).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
ncompare/core.py 92.72% 4 Missing ⚠️
ncompare/printing.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #276      +/-   ##
===========================================
+ Coverage    91.50%   91.62%   +0.12%     
===========================================
  Files            5        5              
  Lines          400      442      +42     
===========================================
+ Hits           366      405      +39     
- Misses          34       37       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielfromearth danielfromearth changed the title Feature/issue 202 have counts of differences categorized attributes dimensions etc Feature/issue 202 have counts of differences categorized (including attributes) Dec 12, 2024
@danielfromearth danielfromearth changed the title Feature/issue 202 have counts of differences categorized (including attributes) Feature/issue 202 - Categorize counts of differences (including attributes) in a summary Dec 12, 2024
@danielfromearth danielfromearth self-assigned this Dec 12, 2024
@danielfromearth danielfromearth added the enhancement New feature or request label Dec 12, 2024
@danielfromearth danielfromearth merged commit c47e401 into develop Dec 12, 2024
11 checks passed
@danielfromearth danielfromearth deleted the feature/issue-202-have-counts-of-differences-categorized-attributes-dimensions-etc branch December 12, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have counts of differences categorized - attributes, dimensions, etc.
1 participant