Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 133 replace example data for no credentials #136

Conversation

danielfromearth
Copy link
Collaborator

@danielfromearth danielfromearth commented Jan 26, 2024

GitHub Issue: #133

Description

Replaced the data files used in the tutorial notebook to examples from NOAA NCEI, so that they require no authentication to access.

Local test steps

N/A

Overview of integration done

Ran the notebook successfully on my local machine. Checked the rebuilt readthedocs page, to confirm that new links work and the output cells look correct.

PR Acceptance Checklist

  • [N/A] Unit tests added/updated and passing.
  • Integration testing
  • CHANGELOG.md updated
  • Documentation updated (if needed).

📚 Documentation preview 📚: https://ncompare--136.org.readthedocs.build/en/136/

@danielfromearth danielfromearth added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 26, 2024
@danielfromearth danielfromearth self-assigned this Jan 26, 2024
@danielfromearth danielfromearth merged commit 8f2b871 into develop Jan 26, 2024
9 checks passed
@danielfromearth danielfromearth deleted the feature/issue-133-replace-example-data-for-no-credentials branch January 26, 2024 21:45
@danielfromearth danielfromearth mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant