HARMONY-1938: Support running harmony without using an EDL app #668
Conversation
…plication. Requires setting an EDL token and disables all access to routes that require group membership for authorization.
…ke it clearer we still use EDL tokens, we just do not use EDL client app.
…e to use an EDL token instead of providing EDL app credentials.
chris-durbin
requested review from
vinnyinverso,
indiejames and
ygliuvt
and removed request for
vinnyinverso and
indiejames
| } else if (eulaInfo.statusCode !== 200) { | ||
| req.context.logger.error(`EULA (${eulaId}) verfification failed. Error: ${eulaInfo.error}`); | ||
| throw new ServerError(`EULA (${eulaId}) verfification failed unexpectedly.`); | ||
| if (env.useEdlClientApp) { |
There was a problem hiding this comment.
I don't understand what whether or not you are a EDL client app has to do with whether or not a user has accepted eulas.
There was a problem hiding this comment.
It requires making a call to EDL that requires a client app so we can't do the check.
|
nit: Maybe consider adding a check in |
There was a problem hiding this comment.
Tested successfully with the harmony-service-example service image built with the harmony-1938 branch of harmony-service-lib-py.
Tested with with and without USE_EDL_CLIENT_APP configuration, harmony dev and harmony-in-a-box locally. Verified service example requests work in all conditions and the admin routes are disabled with permission error when USE_EDL_CLIENT_APP is set to false.
…ing an EDL app and the EDL_TOKEN has not been set.
Jira Issue ID
HARMONY-1938
Description
This change allows developers to run harmony without having to set up an EDL application.
Local Test Steps
There are several configurations to test.
Note any services using the current harmony service library will fail if OAUTH* environment variables are not set. In order to test without an EDL client app you will need to build the service using the harmony-service-library from the harmony-1938 branch.
Test bin/bootstrap and/or bin/create-dotenv with no .env file.
Other Tests
Endpoints that should return authorization errors when not using an EDL_CLIENT_APP
Also verify that the workflow-ui does not show the logs button.
Verify that all other endpoints and functionality work as expected.
PR Acceptance Checklist