HARMONY-1922: Add geometry to STAC item when bbox is defined, but geometry is not #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is defined, but geometry is not
… versions of python
chris-durbin
approved these changes
Oct 17, 2024
ygliuvt
reviewed
Oct 17, 2024
| @@ -181,9 +181,13 @@ def _process_catalog_recursive(self, catalog): | |||
| result.clear_items() | |||
| source = None | |||
| for item in items: | |||
| cloned_item = item.clone() | |||
| # if there is a bbox, but no geometry, create a geometry from the bbox | |||
| if cloned_item.bbox and not cloned_item.geometry: | |||
There was a problem hiding this comment.
Do we know why an item could have bbox, but no geometry?
There was a problem hiding this comment.
Harmony is creating them that way. Up until recently this didn't matter, but pystac started enforcing the spec, so we decided to add the geometry by duplicating the bbox as a polygon.
ygliuvt
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue ID
HARMONY-1922
Description
the STAC spec requires a geometry if a STAC item has a bbox. This is now enforced by pystac. This change adds the
geometry field by creating a Polygon to match the bbox if there is a bbox, but not a geometry defined for the STAC item.
Local Test Steps
make testharmony-service-exampleservice image with this branch and deploy to your local environment. Verify that queries still workPR Acceptance Checklist
Documentation updated (if needed)