Harmony 1764 add support for specifying data operation using a file #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ygliuvt
reviewed
May 17, 2024
harmony/cli.py
Outdated
| @@ -65,6 +65,8 @@ def setup_cli(parser): | |||
| parser.add_argument('--harmony-input', | |||
| help=('the input data for the action provided by Harmony, required for ' | |||
| '--harmony-action=invoke')) | |||
| parser.add_argument('--harmony-input-file', | |||
| help=('the optional path to the input data for the action provided by Harmony, required for ')) | |||
There was a problem hiding this comment.
missing '--harmony-action=invoke'. May also want to change the required for wording.
There was a problem hiding this comment.
actually I meant to delete that part altogether, as it it not required
ygliuvt
approved these changes
May 17, 2024
chris-durbin
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Issue ID
HARMONY-1764
Description
This change adds a new CLI parameter, --harmony-input-file, with which the data operation can be passed on the file system rather than as a command line parameter using --harmony-input. This is needed to support large data operations that were exceeding stack limits when passed using --harmony-input.
Local Test Steps
PR Acceptance Checklist