Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HARMONY-1909, HARMONY-1921: Replace setup.py with pyproject.toml; Fix tutorial notebook; Update WKT LINESTRING docs #95

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

ygliuvt
Copy link
Member

@ygliuvt ygliuvt commented Oct 10, 2024

Jira Issue ID

HARMONY-1909, HARMONY-1921

Description

Replace setup.py with pyproject.toml
Fix tutorial notebook
Update WKT LINESTRING documentation

Local Test Steps

make install
make lint
make test
make docs
Run tutorial notebook and make sure it is successful
Verify readthedocs is built correctly

PR Acceptance Checklist

  • Acceptance criteria met
  • Tests added/updated (if needed) and passing
  • Documentation updated (if needed)

@ygliuvt ygliuvt marked this pull request as ready for review October 11, 2024 19:38
Copy link
Contributor

@chris-durbin chris-durbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out all the make commands successfully. The tutorial.ipynb notebook worked successfully as did most of the others. I noticed a couple issues in notebooks outside the scope of these tickets - one was a harmony bug with retrieving STAC items that I wrote a ticket for, and the pause/resume notebook had setup issues (needs to add another constraint to the request like a bbox and some of the cells should be wrapped in try/catch blocks when we expect errors).

Copy link
Contributor

@indiejames indiejames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all the make commands and notebook

@ygliuvt ygliuvt merged commit e363ec3 into main Oct 16, 2024
11 checks passed
@ygliuvt ygliuvt deleted the harmony-1909 branch October 16, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants