Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HARMONY-1558: renamed .readthedocs.yml to .readthedocs.yaml #71

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

ygliuvt
Copy link
Member

@ygliuvt ygliuvt commented Sep 13, 2023

Jira Issue ID

HARMONY-1558

Description

readthedocs document mentioning .readthedocs.yaml, but we have readthedocs.yml. This update harmony-py to use the same naming convention as readthedocs. I don't think this will fix anything.

Local Test Steps

PR Acceptance Checklist

  • Acceptance criteria met
  • Tests added/updated (if needed) and passing
  • Documentation updated (if needed)

Copy link
Contributor

@chris-durbin chris-durbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming the documentation still builds successfully for this branch.

@ygliuvt
Copy link
Member Author

ygliuvt commented Sep 13, 2023

Approved assuming the documentation still builds successfully for this branch.

I have tried in an old branch on readthedocs and verified the build is successful.

@ygliuvt ygliuvt merged commit 512d999 into main Sep 13, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants