FP-2784: define trace id type #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LeStarch : I don't think I have the permission to merge the approved pull request? This change needs to be merged in-sync with the corresponding fpp change. Can you please let me know what's the best way to do that? |
|
@Shivaly-Reddy The usual process for this it to merge nasa/fpp#517, pre-release FPP and upgrade the pre-release version in requirements.txt here in this PR |
|
Thanks @thomas-bc, Rob gave me the alpha version that would contain the expected changes. Once its released, I'll go ahead and update the requirements.txt. |
|
FPP v2.2.0a5 is now available. |
LeStarch
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Adding a trace id type for FPP.
Rationale
There is a corresponding change being PRed for fpp/main - nasa/fpp#517
Testing/Review Recommendations
Been used and tested with FP-2784 (implementation of Trace features)
Future Work
Trace feature will be added.