Update to FPP v2.1.0a10 #2703
Closed
Update to FPP v2.1.0a10 #2703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimeBaseStoreType is not the same as TimeBase
Cast to the TimeBaseStore type with a known size
Remove unnecessary const casting
For safety's sake!
Existing code was correct but somewhat terse and obscure Refactor and add comments for clarity
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Deserialize length | ||
| // Fail if length exceeds max size (the initial value of actualSize) | ||
| // Otherwise deserialize length bytes and set actualSize to length | ||
| SerializeStatus stat = buffer.deserialize(reinterpret_cast<U8*>(raw), actualSize, Serialization::INCLUDE_LENGTH); |
Check warning
Code scanning / CodeQL
Unchecked function argument Warning
| return buffer.serialize(reinterpret_cast<const U8*>(this->toChar()), len); | ||
| const FwSizeType len = FW_MIN(maxLength, this->length()); | ||
| // Serialize length and then bytes | ||
| return buffer.serialize(reinterpret_cast<const U8*>(this->toChar()), len, Serialization::INCLUDE_LENGTH); |
Check warning
Code scanning / CodeQL
Unchecked function argument Warning
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This was referenced Apr 29, 2024
|
Closing this PR as it has been subsumed by #2707 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fw::StringBasethat was terse and hard to understand (it was not clear what was going on with serializing and deserializing string lengths; because so much was implicit, it looked like the code was serializing and deserializing null-terminated strings).Note: This PR will require some minor changes in user test code, as discussed in nasa/fpp#409. The changes bring the code more into line with approved C++ standards, by eliminating reliance on implicit conversions. I've made the required changes for the F Prime unit tests in this PR.