OSAL clean-up (#2933)

* OSAL clean-up

* Adding comments to file

* Regressing ubuntu-latest to ubuntu-22.04

* Fixing 24.0.4 santizer bug

* Fixing regression in cmd sequencer

* Fixing other cleanups

.github/workflows/autodocs.yml

@@ -7,7 +7,7 @@ on:
 jobs:
   build:
     name: Autodocumentation
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
     - name: "Checkout F´ Repository"
       uses: actions/checkout@v4

.github/workflows/build-test-rpi.yml

@@ -21,7 +21,7 @@ env:
 # A workflow run is made up of one or more jobs that can run sequentially or in parallel
 jobs:
   RPI:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
     - name: "Checkout F´ Repository"
       uses: actions/checkout@v4

.github/workflows/build-test.yml

@@ -19,7 +19,7 @@ on:
 # A workflow run is made up of one or more jobs that can run sequentially or in parallel
 jobs:
   Framework:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
     - name: "Checkout F´ Repository"
       uses: actions/checkout@v4
@@ -39,7 +39,7 @@ jobs:
         retention-days: 5
 
   Ref:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
     - name: "Checkout F´ Repository"
       uses: actions/checkout@v4
@@ -59,7 +59,7 @@ jobs:
         retention-days: 5
 
   Integration:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
     - name: "Checkout F´ Repository"
       uses: actions/checkout@v4
@@ -83,7 +83,7 @@ jobs:
         retention-days: 5
 
   Quality:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
     - name: "Checkout F´ Repository"
       uses: actions/checkout@v4

.github/workflows/cmake-test.yml

@@ -19,7 +19,7 @@ on:
 # A workflow run is made up of one or more jobs that can run sequentially or in parallel
 jobs:
   CMake:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - name: "Checkout F´ Repository"
         uses: actions/checkout@v4

.github/workflows/codeql-jpl-standard.yml

@@ -18,7 +18,7 @@ on:
 jobs:
   analyze:
     name: Analyze
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     permissions:
       actions: read
       contents: read

.github/workflows/codeql-security-scan.yml

@@ -18,7 +18,7 @@ on:
 jobs:
   analyze:
     name: Analyze
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     permissions:
       actions: read
       contents: read

.github/workflows/cppcheck-scan.yml

@@ -16,7 +16,7 @@ on:
 jobs:
   cppcheck:
     name: Cppcheck
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     permissions:
       actions: read
       contents: read

.github/workflows/cpplint-scan.yml

@@ -15,7 +15,7 @@ on:
 jobs:
   cpplint:
     name: Cpplint
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     permissions:
       actions: read
       contents: read

.github/workflows/ext-raspberry-led-blinker.yml

@@ -27,7 +27,7 @@ jobs:
 
   cross-compilation:
     name: "Cross Compilation"
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     needs: get-branch
     steps:
       - name: "Checkout target repository"

.github/workflows/fpp-tests.yml

@@ -15,7 +15,7 @@ on:
 jobs:
   fpptest:
     name: Run FppTest
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
       - name: "Checkout F´ Repository"
         uses: actions/checkout@v4

.github/workflows/markdown-link-check.yml

@@ -8,7 +8,7 @@ on:
 
 jobs:
   markdown-link-check:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     steps:
     - uses: actions/checkout@v4
     - uses: gaurav-nelson/github-action-markdown-link-check@v1

.github/workflows/pip-check.yml

@@ -17,7 +17,7 @@ jobs:
     strategy:
       matrix:
         python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
-        runner: [macos-13, macos-latest, ubuntu-latest]
+        runner: [macos-13, macos-latest, ubuntu-22.04]
         # macos-14 (ARM) currently breaks actions/setup-python with 3.8 and 3.9
         # so we exclude them from the matrix and also test with macos-13 (x86)
         # More info at https://github.com/actions/setup-python/issues/850

.github/workflows/python-format.yml

@@ -10,7 +10,7 @@ on:
 jobs:
   format:
       name: Format
-      runs-on: ubuntu-latest
+      runs-on: ubuntu-22.04
       steps:
       - uses: actions/checkout@v4
       - name: Setup Python 3.8

.github/workflows/reusable-get-pr-branch.yml

@@ -22,7 +22,7 @@ on:
 
 jobs:
   runs:
-    runs-on: "ubuntu-latest"
+    runs-on: "ubuntu-22.04"
     outputs:
       target-branch: ${{ steps.get_target_branch.outputs.TARGET_BRANCH }}
     steps:

.github/workflows/reusable-project-builder.yml

@@ -25,10 +25,10 @@ on:
         type: string
         default: "./fprime"
       runs_on:
-        description: "Platform to run on. Defaults to ubuntu-latest"
+        description: "Platform to run on. Defaults to ubuntu-22.04"
         required: false
         type: string
-        default: "ubuntu-latest"
+        default: "ubuntu-22.04"
       target_platform:
         description: "Target platform to pass to fprime-util"
         required: false

.github/workflows/spelling.yml

@@ -80,7 +80,7 @@ jobs:
       security-events: write
     outputs:
       followup: ${{ steps.spelling.outputs.followup }}
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     if: ${{ contains(github.event_name, 'pull_request') || github.event_name == 'push' }}
     concurrency:
       group: spelling-${{ github.event.pull_request.number || github.ref }}

Fw/Types/test/ut/TypesTest.cpp

@@ -8,7 +8,6 @@
 #include <Fw/Types/Serializable.hpp>
 #include <Fw/Types/String.hpp>
 #include <Fw/Types/StringTemplate.hpp>
-#include <Os/InterruptLock.hpp>
 #include <Os/IntervalTimer.hpp>
 //
 // Created by mstarch on 12/7/20.