Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add force option to generate that will call purge before generating, … #217

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

csmith608
Copy link
Contributor

…still need to check edgecases

Related Issue(s) nasa/fprime#2887
Has Unit Tests (y/n) n
Documentation Included (y/n) n

Change Description

Implements force generate the runs a purge

Rationale

QoL

Testing/Review Recommendations

fprime-util generate --force

Future Work

@csmith608 csmith608 marked this pull request as ready for review September 23, 2024 21:00
@csmith608
Copy link
Contributor Author

@LeStarch

@csmith608
Copy link
Contributor Author

@thomas-bc

Copy link
Collaborator

@LeStarch LeStarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when you purge -f then generate -f. That will purge a second time, does that error?

Otherwise this looks great!

@csmith608
Copy link
Contributor Author

@LeStarch that's fine because the generate -f goes through all the purge logic so it realized those directories don't exist.

This is the result from generate -f

[INFO] Purge build directory at: /Users/crsmith/Documents/fprime/Ref/build-fprime-automatic-native
[INFO] Purge build directory at: /Users/crsmith/Documents/fprime/Ref/build-fprime-automatic-native-ut
[INFO] Skipping purge. The following directory does not exist: /Users/crsmith/Documents/fprime/Ref/build-fprime-automatic-native-ut

@LeStarch LeStarch self-requested a review September 23, 2024 22:46
LeStarch
LeStarch previously approved these changes Sep 23, 2024
@LeStarch LeStarch requested a review from thomas-bc September 23, 2024 22:46
Copy link
Contributor

@thomas-bc thomas-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion

src/fprime/fbuild/cli.py Show resolved Hide resolved
src/fprime/fbuild/cli.py Outdated Show resolved Hide resolved
@thomas-bc thomas-bc merged commit d1704ae into nasa:devel Oct 14, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants