Swap regCommands()
and configTopology
+ Move Buffmgr and Framing setup to front
#208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Swap
regCommands()
andconfigureTopology()
in Topology.cppMove BufferManager Setup and Framing/Deframing setup to front in
configureTopology()
in Topology.cppRationale
Registering commands also generates events as a byproduct. In a hub pattern implementation connected to eventLogging, the hub will assert since it tries to handle the events before
configureTopology()
is called (and the bufferManager is not setup).There may be other similar implementations from other projects that require a more specific setup before their components are ready to handle commands and events.
Have not found a use case to handle commands before the system setup is completed.
BufferManager and Framing/Deframing should be setup before
readParamFile()
is called. This also sends an event and the hub would assert before the bufferManager and deframer is setup.Testing/Review Recommendations
CI to ensure standard projects are working correctly
CC: @timcanham @LeStarch @bocchino @Joshua-Anderson