Remove upper bounds on dependency requirements #114
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.py
Change Description
Removing the upper bounds on dependency requirements in the
setup.py
in preparation for version bumps in F' core requirements.txtRationale
Python package versions need bumping as some are insecure. This will be done in the requirements.txt in F', but we need to loosen the requirements on fprime-tools as there are upper bounds. I chose to remove the upper bounds altogether for the following reasons:
The only downside of this approach that I could identify is that there is a very small probability that by installing an external dependency in the virtual environment, that dependency will introduce an upgrade of one of fprime's dependency - and that upgrade might break things...
Let me know what you think