Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CI to manylinux_2_28_x86_64 #539

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Conversation

thomas-bc
Copy link
Contributor

@thomas-bc thomas-bc commented Dec 3, 2024

Fix CI

Rationale

  1. Python 3.8 is EOL as of a month ago. Python 3.9 supports manylinux_x_y format
  2. RHEL8 is GLIBC 2.28
  3. Ubuntu22.04 is 2.28+

Thus, we can upgrade to manylinux_x_y with GLIBC <= 2.28

Note: Ubuntu20.04 users must upgrade pip inside their virtual environment if they are using the system Python

TODO

  • Update system requirements to Python 3.8.10+
  • Update builds that run Python less than 3.8.10

@bocchino
Copy link
Collaborator

bocchino commented Dec 3, 2024

Thanks! It looks like GitHub may also be refusing to run the Mac OS 12 job:

https://github.com/nasa/fpp/actions/runs/12146022043/job/33869670896?pr=539

@bocchino
Copy link
Collaborator

bocchino commented Dec 3, 2024

Can you revise this PR so that it merges into release/v2.2.1? We need this for the release.

@thomas-bc thomas-bc changed the base branch from main to release/v2.2.1 December 3, 2024 19:57
Copy link
Collaborator

@bocchino bocchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bocchino bocchino merged commit 4746be2 into release/v2.2.1 Dec 3, 2024
11 checks passed
@bocchino bocchino deleted the fix-ci-manylinux branch December 3, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants