Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #17, add validation for rtncode and update bracket to standard #20

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Fix #17, add validation for rtncode and update bracket to standard #20

merged 1 commit into from
Oct 23, 2019

Conversation

avan989
Copy link
Contributor

@avan989 avan989 commented Oct 2, 2019

Describe the contribution
Fix #17. Resolve warning with flags -Wall -std=c99 -pedantic -Wstrict-prototypes -Wwrite-strings

Testing performed
Steps taken to test the contribution:

  1. Build
  2. Verify warning does not appear
  3. Execute elf2cfetbl against table object
  4. Verify *.tbl is generated
  5. Execute again with DDD
  6. Force RtnCode = -1
  7. Verify *.tbl is generated

Expected behavior changes
No impact to behavior

System(s) tested on:

  • Hardware
  • Ubuntu 18.04.03
  • elf2cfetbl version 3.1.0, cFE 6.7.0

Contributor Info
Anh Van, NASA Goddard

Community contributors
You must attach a signed CLA (required for acceptance) or reference one already submitted

@skliper skliper added this to the 3.2.0 milestone Oct 8, 2019
@skliper skliper added the CCB:Approved Indicates code approval by CCB label Oct 10, 2019
jphickey added a commit that referenced this pull request Oct 11, 2019
@jphickey
CCB 2019-10-09: Approved pull requests #15, #20, #21, #23, #24
2a9964a 
Merge branches 'pull-15', 'pull-20', 'pull-21', 'pull-23'
and 'pull-24' for integration
@jphickey jphickey mentioned this pull request Oct 21, 2019
Merged
@jphickey jphickey merged commit e888ec0 into nasa:master Oct 23, 2019
@skliper skliper modified the milestone: 3.2.0 Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skliper skliper skliper approved these changes

Assignees
No one assigned
Labels
CCB:Approved Indicates code approval by CCB
Projects
None yet
Milestone
Bootes
Development

Successfully merging this pull request may close these issues.

Add validation for returncode and fix bracket to standard
3 participants
@avan989 @skliper @jphickey