Fix #129, Reduce cyclomatic complexity of GetElfHeader #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chillfig
force-pushed
the
reduce_cycloComplex
branch
from
b0cba9c
to
2295974
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
elf2cfetbl.c
Outdated
| * | ||
| */ | ||
|
|
||
| int32 GetElfHeader(void) |
Check notice
Code scanning / CodeQL
Long function without assertion Note
elf2cfetbl.c
Outdated
| * | ||
| */ | ||
|
|
||
| int32 GetElfHeader(void) |
Check notice
Code scanning / CodeQL
Function too long Note
chillfig
force-pushed
the
reduce_cycloComplex
branch
from
2295974
to
e0ffd26
Compare
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Sep 1, 2023
*Combines:* cFE v7.0.0-rc4+dev384 psp v1.6.0-rc4+dev90 osal v6.0.0-rc4+dev229 elf2cfetbl v3.3.0-rc4+dev36 ci_lab v2.5.0-rc4+dev47 **Includes:** *cFE* - nasa/cFE#2401 - nasa/cFE#2403 - nasa/cFE#2380 - nasa/cFE#2400 - nasa/cFE#2420 *psp* - nasa/PSP#395 - nasa/PSP#400 *osal* - nasa/osal#1409 *elf2cfetbl* - nasa/elf2cfetbl#137 - nasa/elf2cfetbl#136 *ci_lab* - nasa/ci_lab#143 Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com> Co-authored by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Jacob Killelea <jkillelea@users.noreply.github.com> Co-authored by: Dylan Z. Baker <dzbaker@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Sep 1, 2023
*Combines:* cFE v7.0.0-rc4+dev384 psp v1.6.0-rc4+dev90 osal v6.0.0-rc4+dev229 elf2cfetbl v3.3.0-rc4+dev36 ci_lab v2.5.0-rc4+dev47 **Includes:** *cFE* - nasa/cFE#2401 - nasa/cFE#2403 - nasa/cFE#2380 - nasa/cFE#2400 - nasa/cFE#2420 *psp* - nasa/PSP#395 - nasa/PSP#400 *osal* - nasa/osal#1409 *elf2cfetbl* - nasa/elf2cfetbl#137 - nasa/elf2cfetbl#136 *ci_lab* - nasa/ci_lab#143 Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com> Co-authored by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Jacob Killelea <jkillelea@users.noreply.github.com> Co-authored by: Dylan Z. Baker <dzbaker@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Sep 1, 2023
*Combines:* cFE v7.0.0-rc4+dev384 psp v1.6.0-rc4+dev90 osal v6.0.0-rc4+dev229 elf2cfetbl v3.3.0-rc4+dev36 ci_lab v2.5.0-rc4+dev47 **Includes:** *cFE* - nasa/cFE#2401 - nasa/cFE#2403 - nasa/cFE#2380 - nasa/cFE#2400 - nasa/cFE#2420 *psp* - nasa/PSP#395 - nasa/PSP#400 *osal* - nasa/osal#1409 *elf2cfetbl* - nasa/elf2cfetbl#137 - nasa/elf2cfetbl#136 *ci_lab* - nasa/ci_lab#143 Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com> Co-authored by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Jacob Killelea <jkillelea@users.noreply.github.com> Co-authored by: Dylan Z. Baker <dzbaker@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Sep 1, 2023
*Combines:* cFE v7.0.0-rc4+dev384 psp v1.6.0-rc4+dev90 osal v6.0.0-rc4+dev229 elf2cfetbl v3.3.0-rc4+dev36 ci_lab v2.5.0-rc4+dev47 **Includes:** *cFE* - nasa/cFE#2401 - nasa/cFE#2403 - nasa/cFE#2380 - nasa/cFE#2400 - nasa/cFE#2420 *psp* - nasa/PSP#395 - nasa/PSP#400 *osal* - nasa/osal#1409 *elf2cfetbl* - nasa/elf2cfetbl#137 - nasa/elf2cfetbl#136 *ci_lab* - nasa/ci_lab#143 Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com> Co-authored by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Jacob Killelea <jkillelea@users.noreply.github.com> Co-authored by: Dylan Z. Baker <dzbaker@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Sep 1, 2023
*Combines:* cFE v7.0.0-rc4+dev384 psp v1.6.0-rc4+dev90 osal v6.0.0-rc4+dev229 elf2cfetbl v3.3.0-rc4+dev36 ci_lab v2.5.0-rc4+dev47 **Includes:** *cFE* - nasa/cFE#2401 - nasa/cFE#2403 - nasa/cFE#2380 - nasa/cFE#2400 - nasa/cFE#2420 *psp* - nasa/PSP#395 - nasa/PSP#400 *osal* - nasa/osal#1409 *elf2cfetbl* - nasa/elf2cfetbl#137 - nasa/elf2cfetbl#136 *ci_lab* - nasa/ci_lab#143 Co-authored by: Justin Figueroa <chillfig@users.noreply.github.com> Co-authored by: Jacob Hageman <skliper@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com> Co-authored by: Jacob Killelea <jkillelea@users.noreply.github.com> Co-authored by: Dylan Z. Baker <dzbaker@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
This change reduces the cyclomatic complexity by 5. The changes specifically condense extraneous "Verbose" if statements for printing header as well as extraneous status assignments when checking the elf magic number.
Testing performed
None
Expected behavior changes
No expected impact to behavior.
System(s) tested on
Additional context
The cyclomatic complexity for this function still remains above the recommended 15, however the code is relatively clean and follows a pretty straightforward process. If desired, further reduction of cylomatic complexity by 8 can be achieved by creating new functions for the processor class type verification and data encoding type verification switch/case.
Third party code
N/A
Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, Vantage Systems