Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration Candidate 20190906 #13

Merged
merged 2 commits into from
Sep 16, 2019
Merged

Integration Candidate 20190906 #13

merged 2 commits into from
Sep 16, 2019

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Sep 6, 2019 •
edited
Loading

Describe the contribution
Merge of CCB 20190904 approved commits.
Fixes #8

Testing performed
Steps taken to test the contribution:

  1. Checked out http://github.com/nasa/cFS master and followed setup instructions
  2. Checked out ic-20190906
  3. Followed standard build instructions (no cmdUtil build warnings observed)

Expected behavior changes

  • No impact to behavior from this change, just replaced deprecated dependencies

System(s) tested on:

  • Server
  • OS: Ubuntu/Linux 4.4.0-146-generic
  • Versions: bundle release candidate 6.7 with this branch

Additional context
None

Contributor Info
Jacob Hageman/NASA

Community contributors
CLA on file

skliper and others added 2 commits September 6, 2019 14:57
@skliper
Fix #8, Replace deprecated defines
339a4ec
@skliper
CCB 2019-09-04: Merge #8
a975cb2 
Reviewed and approved at 2019-09-04 CCB
@skliper
Copy link
Contributor Author

skliper commented Sep 6, 2019

@avan989 Could you use this branch to build a table and verify it still works (no behavior changes)?

@skliper
Copy link
Contributor Author

skliper commented Sep 6, 2019 •
edited
Loading

Not backwards compatible with cFE 6.6 and requires use of the 6.7 release candidate

@skliper skliper changed the title Integration Candidate 20190906 [WIP] - Integration Candidate 20190906 Sep 6, 2019
@skliper skliper changed the title [WIP] - Integration Candidate 20190906 Integration Candidate 20190906 Sep 6, 2019
@skliper skliper added this to the 3.1.0 milestone Sep 6, 2019
jphickey
jphickey approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this builds and runs for me, works as expected.

@skliper skliper merged commit a975cb2 into master Sep 16, 2019
@skliper skliper deleted the ic-20190906 branch September 16, 2019 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jphickey jphickey jphickey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Aquila
Development

Successfully merging this pull request may close these issues.

Remove dependencies on deprecated elements
2 participants
@skliper @jphickey