Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elf2cfetbl classic build include path order issues #4

Closed
skliper opened this issue Jun 24, 2019 · 3 comments
Closed

elf2cfetbl classic build include path order issues #4

skliper opened this issue Jun 24, 2019 · 3 comments
Assignees
@avan989
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Jun 24, 2019

Originated by abrown (67 on babelfish):

elf2cfetbl Makefile doesn't include paths in the correct order (classic build)

Using cFE 6.5.0a with the "classic" makefile system: the tools/elf2cfetbl/for_build/Makefile has include paths in the wrong order such that it always picks up config files from the defined source first, rather than what is in your actual mission or local build directory. Ex: you change OS_MAX_FILE_NAME in your flight build and there is a table header mismatch with elf2cfetbl.
@skliper skliper added the bug Something isn't working label Jun 24, 2019
@skliper skliper added this to the 3.1.0 milestone Jun 24, 2019
@skliper
Copy link
Contributor Author

skliper commented Jun 24, 2019

Really just need to deprecate/cleanup/remove classic build artifacts.

@skliper skliper added the good first issue Good for newcomers label Jun 24, 2019
@skliper skliper removed this from the 3.1.0 milestone Sep 16, 2019
@skliper
Copy link
Contributor Author

skliper commented Oct 1, 2019

@avan989 - want to take this one? Just delete for_build and the top Makefile. Both are obsolete.

@avan989
Copy link
Contributor

avan989 commented Oct 2, 2019

sure

skliper added a commit that referenced this issue Oct 2, 2019
@skliper
Merge pull request #18 from avan989/issue_4_classic_build
11218e6 
issue #4, delete for_build and top Makefile
skliper added a commit that referenced this issue Oct 2, 2019
@skliper
CCB 2019-09-25: Merge #2, #4
9f4749c 
Reviewed and approved at 2019-09-25 CCB
skliper added a commit that referenced this issue Oct 2, 2019
@skliper
FASTTRACK: Merge #2, #4
be009b1 
Print format change and classic build support removal
@skliper skliper closed this as completed in 9c691ad Oct 2, 2019
@skliper skliper added this to the 3.2.0 milestone Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avan989 avan989

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
Bootes
Development

No branches or pull requests
2 participants
@avan989 @skliper