ci_lab Integration Candidate: 2020-12-08

[astrogeco]

Describe the contribution

Fix #62, Apply message alignment pattern

Testing performed
See https://github.com/nasa/cFS/pull/160/checks

Expected behavior changes
PR #63 - Aligns messages according to changes in cFE nasa/cFE#1009. Uses the "raw" message cmd/tlm types in definition

System(s) tested on
Ubuntu 18.04

Additional context
Part of nasa/cFS#160

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
@skliper

[astrogeco]

@skliper having some trouble after merging #63
EDIT: haven't merged nasa/cFE#1015 yet

See https://github.com/astrogeco/cFS/runs/1481379928?check_suite_focus=true

In file included from /home/runner/work/cFS/cFS/apps/ci_lab/fsw/src/ci_lab_app.c:32:0:
/home/runner/work/cFS/cFS/apps/ci_lab/fsw/src/ci_lab_app.h:66:34: error: unknown type name ‘CFE_SB_Buffer_t’; did you mean ‘CFE_SB_TlmHdr_t’?
 void CI_LAB_ProcessCommandPacket(CFE_SB_Buffer_t *SBBufPtr);
                                  ^~~~~~~~~~~~~~~
                                  CFE_SB_TlmHdr_t

[skliper]

@astrogeco - yup, won't work until the fix for nasa/cFE#1009 (nasa/cFE#1015) is in.

[astrogeco]

@skliper got an error when running cFS
See https://github.com/nasa/cFS/actions/runs/408945590. You can see the startup file by scrolling to the bottom in the "artifacts" section. Is this a setup issue on the testing side?

1980-012-14:03:48.50227 POWERON RESET called from CFE_ES_ResetCFE (Commanded).
CFE_PSP: Exiting cFE with POWERON Reset status.
EVS Port1 66/1/CFE_SB 17: Msg Limit Err,MsgId 0x1806,pipe ES_CMD_PIPE,sender CI_LAB_APP
CFE_PSP: Critical Data Store Shared memory segment removed
Reset Area Shared memory segment removed
EVS Port1 66/1/CFE_SB 17: Msg Limit Err,MsgId 0x1806,pipe ES_CMD_PIPE,sender CI_LAB_APP
User Reserved Area Shared memory segment removed
EVS Port1 66/1/CFE_SB 17: Msg Limit Err,MsgId 0x1806,pipe ES_CMD_PIPE,sender CI_LAB_APP
EVS Port1 66/1/CFE_SB 17: Msg Limit Err,MsgId 0x1806,pipe ES_CMD_PIPE,sender CI_LAB_APP

[skliper]

@astrogeco I was able to recreate on a dev vm, so not specific to your setup.

[skliper]

@astrogeco pushed hotfix. I shouldn't have removed the cast on the size comparison to catch negative return status.