Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #96, Check returns from CFE calls during init #132

Merged

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Nov 8, 2022

Checklist

Describe the contribution

  • Fixes Check Return Value of CFE_SB_CreatePipe  #96
    • Returns from CFE_EVS_Register(), CFE_SB_CreatePipe(), and CFE_SB_Subscribe() during CI_LAB initialization sequence that are != CFE_SUCCESS will now generate an EVS event reporting the error.
    • Also added new Event IDs for these error events.

Testing performed
Build + Run cFS locally to confirm CI_LAB still running fine with these changes.
Screenshot 2022-11-08 11 13 53
Also ran with inverse for each event (checking if status == CFE_SUCCESS) to confirm structure and format of events is fine - they are shown here:
Screenshot 2023-03-21 08 53 55

Expected behavior changes
Program logic not changed, but new events reports will now be generated for failures generated by these CFE calls.

System(s) tested on
Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64
Debian GNU/Linux 11 (bullseye)
Current main branch cFS bundle.

Contributor Info
Avi @thnkslprpt

@dzbaker dzbaker added this to the Fornax milestone Nov 21, 2022
@dzbaker dzbaker modified the milestones: Fornax, Equuleus Dec 7, 2022
@thnkslprpt thnkslprpt force-pushed the fix-96-check-returns-from-init-cfe-calls branch from 0b50c09 to 1b78541 Compare March 20, 2023 23:05
@github-advanced-security
Copy link

You have successfully added a new CppCheck configuration cppcheck. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-advanced-security
Copy link

You have successfully added a new CodeQL-coding-standard configuration coding-standard. As part of the setup process, we have scanned this repository and found 12 existing alerts. Please check the repository Security tab to see all alerts.

@github-advanced-security
Copy link

You have successfully added a new CodeQL-security configuration security. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@thnkslprpt thnkslprpt force-pushed the fix-96-check-returns-from-init-cfe-calls branch from 1b78541 to 9f37dde Compare November 1, 2023 19:09
@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Nov 2, 2023
@dzbaker dzbaker added CCB:Approved Indicates code approval by CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Nov 2, 2023
@dmknutsen
Copy link
Contributor

dmknutsen commented Nov 8, 2023

@thnkslprpt Can you replace CI_LAB_INIT_INF_EID with CI_LAB_STARTUP_INF_EID?

@thnkslprpt thnkslprpt force-pushed the fix-96-check-returns-from-init-cfe-calls branch from daca072 to d5e6f3c Compare November 9, 2023 05:14
@thnkslprpt thnkslprpt force-pushed the fix-96-check-returns-from-init-cfe-calls branch from d5e6f3c to 5c3d843 Compare November 9, 2023 05:20
@thnkslprpt
Copy link
Contributor Author

@thnkslprpt Can you replace CI_LAB_INIT_INF_EID with CI_LAB_STARTUP_INF_EID?

@dmknutsen I rebased to main and all passing now (was able to leave it with the updated CI_LAB_INIT_INF_EID version [90% of the cFS apps/components use INIT rather than STARTUP]) - is that cool?

@dmknutsen
Copy link
Contributor

Yep - that works. Thanks Avi!

@dmknutsen dmknutsen merged commit 7e46009 into nasa:main Nov 9, 2023
11 checks passed
@thnkslprpt thnkslprpt deleted the fix-96-check-returns-from-init-cfe-calls branch November 9, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code approval by CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check Return Value of CFE_SB_CreatePipe
4 participants