Fix #509, Rename Tool for CodeQL Results #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArielSAdamsNASA
added
CCB:Ready
ArielSAdamsNASA
force-pushed
the
fix-509-rename-tool-codeql-results
branch
from
d1a8222
to
c61a326
Compare
ArielSAdamsNASA
force-pushed
the
fix-509-rename-tool-codeql-results
branch
from
c61a326
to
c14a1f7
Compare
skliper
approved these changes
Jun 17, 2022
|
@ArielSAdams can you add a screeenshot of how this change affects the code-scanning results page? |
Provided screenshot. |
astrogeco
added
CCB:Approved
|
CCB:2022-06-22 APPROVED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fixes #509
Testing performed
Tested on fork here: https://github.com/ArielSAdams/cFS/actions/runs/2509680609
Tested renaming SARIF file here: https://github.com/ArielSAdams/cFS/actions/runs/2510376525
Expected behavior changes
Users can filter between coding standard results and security results for CodeQL by Tool in code scanning alerts.
The CodeQL sarif file, by default, is named cpp.sarif. The default file is renamed to Codeql-${{ matrix.scan-type }}.sarif so when users download the artifacts from cppcheck and CodeQL, they are not confusing one for the other.
Downside is that the number of alerts are not shown.
Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal