Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - add test build/run with elevated privileges #107

Open
skliper opened this issue Jun 29, 2020 · 3 comments
Open

CI - add test build/run with elevated privileges #107

skliper opened this issue Jun 29, 2020 · 3 comments

Comments

@skliper
Copy link
Contributor

skliper commented Jun 29, 2020

Is your feature request related to a problem? Please describe.
CI only builds/runs with user privileges

Describe the solution you'd like
Add an elevated privileges build/run

Describe alternatives you've considered
None.

Additional context
See #95 for additional update request

Requester Info
Jacob Hageman - NASA/GSFC

@astrogeco
Copy link
Contributor

Can you add more context to this? It seems like nasa/osal#528 needs it but I think we can add a more specific rationale in this issue
.

@skliper
Copy link
Contributor Author

skliper commented Jul 1, 2020

Different logic/code path is exercised for a privileged user run. Without including it in CI, we are not covering this code. Basically low hanging fruit (easy change) to get more coverage from CI. There is plenty of other code we don't cover (we don't do any build verification), but just a privileged run will at least avoid breakage like nasa/osal#528.

@jphickey
Copy link
Contributor

jphickey commented Jul 1, 2020

@astrogeco - this is why the original testing of PR nasa/osal#508 didn't show an issue - either locally for me or in CI. It was noticed by a user who cloned the code and ran it as root. When running as root some additional thread attributes are set that only a privileged user can do.

I'm working on some docker-based CI scripts in the background and this should be covered by those tests. For the current CI it just means adding/changing at least one make test command to run in sudo, which should cover it.

astrogeco added a commit to astrogeco/cFS that referenced this issue Dec 1, 2020
astrogeco added a commit to astrogeco/cFS that referenced this issue Dec 2, 2020
@astrogeco astrogeco added the good first issue Good for newcomers label Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants