Fix #835, build tables for static apps #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixup the table build targets so it will be invoked for both static and dynamic apps. Improve the prep log messages to indicate the targets that tables will be built for for both static and dynamic apps.
jphickey
added
the
CCB:Ready
|
CCB 2020-11-04 APPROVED |
astrogeco
added
CCB-20201104
and removed
CCB:Ready
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Nov 10, 2020
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Nov 16, 2020
* Add nasa/cFE#984 * Add nasa/cFE#980 * Add nasa/cFE#867 * Add nasa/osal#638 and update cfe due to rebase * Add nasa/cFE#987 * Add nasa/to_lab#64 and nasa/sample_app#104 * Add nasa/osal#643 * Add nasa/cFE#1000 * Add nasa/ci_lab#58 * Add doxygen fixes for nasa/osal#643 * Add nasa/cFE#1013 * Add nasa/cFE#1011 * Add nasa/ci_lab#61 * Add nasa/sample_app#109 * Bump versions and point to submodules main Co-authored-by: Joseph Hickey <joseph.p.hickey@nasa.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixup the table build targets so it will be invoked for both static and dynamic apps.
Improve the prep log messages to indicate the targets that tables will be built for for both static and dynamic apps.
Fixes #835
Testing performed
Locally changed "sample_app" to be a static app instead of dynamic app.
Confirmed table file is now correctly built and app runs normally and is able to load the table file.
Expected behavior changes
Table works correctly as static app.
System(s) tested on
Ubuntu 20.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.