Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #412, Clean up table services comments/references #454

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

dmknutsen
Copy link
Contributor

@dmknutsen dmknutsen commented Jan 6, 2020

Describe the contribution
Fixes #412

Note that there were a couple cases where function prototypes were defined in the wrong header
files. This was also cleaned up as part of this issue.

Testing performed
Testing consisted of building/running the software and re-running the unit tests.

  1. Build steps:
    make prep
    make
    make install
  2. Ran software:
    ./core-cpu1

Expected behavior changes
None

System(s) tested on:
Oracle VM VirtualBox
OS: ubuntu-19.10
Version: cFE 6.7.3.0; OSAL 5.0.3.0; PSP 1.4.1.0

Additional context
None

Contributor Info
Dan Knutsen
GSFC/NASA

@skliper
Copy link
Contributor

skliper commented Jan 6, 2020

Lets talk about this one off-line prior to CCB review.

@skliper skliper changed the title Fixes #412 Fix #412, Clean up table services comments/references Jan 7, 2020
@skliper skliper added the CCB:Approved Indicates code review and approval by community CCB label Jan 21, 2020
@skliper
Copy link
Contributor

skliper commented Jan 21, 2020

CCB 20200115 - Reviewed and approved for CI

@skliper skliper changed the base branch from master to ic-20200121 January 21, 2020 22:41
@skliper
Copy link
Contributor

skliper commented Jan 21, 2020

Commit message amend only

@skliper skliper merged commit fec6a48 into nasa:ic-20200121 Jan 21, 2020
@skliper skliper added this to the 6.8.0 milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants