Fix #2451, minor reorg of message headers #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puts the message encapsulation in a separate header from the message payload. Also puts all headers into the "header-check" target as there were some inclusion dependencies noted.
jphickey
force-pushed
the
fix-2451-msgstruct
branch
from
9982242
to
b7f70cd
Compare
jphickey
added
the
CCB:Ready
dzbaker
added
CCB:Approved
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Oct 18, 2023
*Combines:* cFE v7.0.0-rc4+dev401 psp v1.6.0-rc4+dev96 **Includes:** *cFE* - nasa/cFE#2453 *psp* - nasa/PSP#406 - nasa/PSP#410 Co-authored by: Anh Van <avan989@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Oct 18, 2023
*Combines:* cFE v7.0.0-rc4+dev401 psp v1.6.0-rc4+dev96 **Includes:** *cFE* - nasa/cFE#2453 *psp* - nasa/PSP#406 - nasa/PSP#410 Co-authored by: Anh Van <avan989@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Puts the message encapsulation in a separate header from the message payload. Also puts all headers into the "header-check" target as there were some inclusion dependencies noted.
Fixes #2451
Testing performed
Build and run all tests
Expected behavior changes
None
System(s) tested on
Debian
Additional context
This is primarily to improve maintainability and resolve inclusion issues in other modules
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.