Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1093, Align Pipe ID/Name reporting in SB event strings #2265

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Mar 27, 2023

Checklist

Describe the contribution

  • Fixes Inconsistent Pipe ID reporting in SB events #1093
    • Removed the debug event from successful execution of CFE_SB_GetPipeName() and deleted the CFE_SB_GETPIPENAME_EID (CFE_SB_GetPipeName() was its only instance of use)
    • Updated all SB events that include the Pipe ID/Name in the event string to use the PipeId for nominal/success and PipeName for error cases (except where deviations are desirable)
    • Updated the format specifiers for PipeIds to %lx (if they weren't already set as such)

Expected behavior changes
No change to behavior other than what is outlined above.

Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Local tests confirm no change to coverage.

System(s) tested on
Intel(R) Celeron(R) N4100 CPU @ 1.10GHz x86_64
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS.

Contributor Info
Avi Weiss @thnkslprpt

@thnkslprpt thnkslprpt force-pushed the fix-1093-align-pipeid-name-reporting-in-sb branch from 09364d7 to 1ba7001 Compare May 5, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Pipe ID reporting in SB events
1 participant