Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2076, Improve ES unit test coverage #2081

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Apr 6, 2022

Describe the contribution

Testing performed
Build/run unit tests and confirmed coverage

Expected behavior changes
Improves coverage

System(s) tested on

  • Hardware: i5/wsl
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
Also tightened up the coverage enforcement

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Apr 6, 2022
@skliper skliper added this to the Draco milestone Apr 6, 2022
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Apr 13, 2022
@astrogeco
Copy link
Contributor

CCB:2022-04-13 APPROVED

astrogeco added a commit to nasa/cFS that referenced this pull request Apr 18, 2022
astrogeco added a commit to nasa/cFS that referenced this pull request Apr 18, 2022
astrogeco added a commit to nasa/cFS that referenced this pull request Apr 18, 2022
@astrogeco astrogeco merged commit 9d087e1 into nasa:main Apr 19, 2022
astrogeco added a commit to nasa/cFS that referenced this pull request Apr 19, 2022
**Combines**

nasa/cFE#2091 v7.0.0-rc4+dev110

**Includes**

*cFE*

nasa/cFE#2077, Remove contributor license agreement

nasa/cFE#2085, Use reusable documentation generation workflow

nasa/cFE#2080, Add config module to coverage enforcemnt

nasa/cFE#2081, Improve ES unit test coverage

nasa/cFE#2082, Only increment SB InternalErrorCounter on errors

*osal*

nasa/osal#1246, Apply latest contributor license agreement links

*PSP*

nasa/PSP#331, Apply latest contributor license agreement links

nasa/PSP#334, Fix input to static analysis workflow

Co-authored-by: Jacob Hageman    <skliper@users.noreply.github.com>
Co-authored-by: Justing Figueroa <chillfigskliper@users.noreply.github.com>
astrogeco added a commit to nasa/cFS that referenced this pull request Apr 19, 2022
**Combines**

nasa/cFE#2091 v7.0.0-rc4+dev110

**Includes**

*cFE*

nasa/cFE#2077, Remove contributor license agreement

nasa/cFE#2085, Use reusable documentation generation workflow

nasa/cFE#2080, Add config module to coverage enforcemnt

nasa/cFE#2081, Improve ES unit test coverage

nasa/cFE#2082, Only increment SB InternalErrorCounter on errors

*osal*

nasa/osal#1246, Apply latest contributor license agreement links

*PSP*

nasa/PSP#331, Apply latest contributor license agreement links

nasa/PSP#334, Fix input to static analysis workflow

Co-authored-by: Jacob Hageman    <skliper@users.noreply.github.com>
Co-authored-by: Justing Figueroa <chillfig@users.noreply.github.com>
@skliper skliper deleted the fix2076-modsrcvercallback_coverage branch April 19, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB draco-rc2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ES missing coverage in cfe_es_task.c of CFE_ES_ModSrcVerCallback
2 participants