Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1030 change test_MSG to UT_DisplayPkt #1046

Conversation

zanzaben
Copy link
Contributor

@zanzaben zanzaben commented Dec 9, 2020

Describe the contribution
Fixes #1030
Removed Test_MSG_PrintMsg and and replaced it with UT_DisplayPkt. Also removed Test_MSG_Sum since it was not being used.

Testing performed
Build and run unit test.

Expected behavior changes
None

System(s) tested on
Ubuntu 20.04

Contributor Info - All information REQUIRED for consideration of pull request
Alex Campbell GSFC

@zanzaben zanzaben added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Dec 9, 2020
@skliper
Copy link
Contributor

skliper commented Dec 9, 2020

@excaliburtb - will impact custom header, I was lazy and used the sum function at first, better to test individual elements as done in the open source msg module. UT_DisplayPkt is a direct replacement.

@skliper skliper added this to the 7.0.0 milestone Dec 9, 2020
@zanzaben zanzaben force-pushed the fix1030_remove_test_MSG_PrintMsg branch from 423b425 to 3f19a9e Compare December 14, 2020 15:06
@zanzaben zanzaben force-pushed the fix1030_remove_test_MSG_PrintMsg branch from 3f19a9e to a83df5e Compare December 14, 2020 16:29
@astrogeco astrogeco added CCB-20201216 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Dec 16, 2020
@astrogeco
Copy link
Contributor

CCB 2020-12-16 APPROVED

@astrogeco astrogeco changed the base branch from main to integration-candidate December 18, 2020 14:31
@astrogeco astrogeco merged commit 00ba621 into nasa:integration-candidate Dec 18, 2020
astrogeco added a commit to nasa/cFS that referenced this pull request Dec 18, 2020
@zanzaben zanzaben deleted the fix1030_remove_test_MSG_PrintMsg branch February 9, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Test_MSG_PrintMsg in favor of UT_DisplayPkt
3 participants