Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create accessor functions for Counter resources #870

Closed
jphickey opened this issue Sep 9, 2020 · 0 comments · Fixed by #876
Closed

Create accessor functions for Counter resources #870

jphickey opened this issue Sep 9, 2020 · 0 comments · Fixed by #876
Labels
enhancement
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

jphickey commented Sep 9, 2020

Is your feature request related to a problem? Please describe.
The generic counter API uses a zero based ID to directly index an array

Describe the solution you'd like
Make the "generic counter" API follow the same pattern as was done for apps and tasks in #797

Additional context
This is for consistency and future development. All resource management should follow this pattern.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
jphickey added a commit to jphickey/cFE that referenced this issue Sep 9, 2020
@jphickey
Fix nasa#870, Counter accessor methods
193d9bb 
Apply the appid/taskid pattern to Generic Counter resources.
No real logic change - just putting the repeated logic into
inline functions.
jphickey added a commit to jphickey/cFE that referenced this issue Sep 9, 2020
@jphickey
Fix nasa#870, Counter accessor methods
5ebd865 
Apply the appid/taskid pattern to Generic Counter resources.
No real logic change - just putting the repeated logic into
inline functions.
@skliper skliper added this to the 7.0.0 milestone Sep 9, 2020
yammajamma added a commit that referenced this issue Sep 10, 2020
@yammajamma
Merge pull request #871 from jphickey/fix-870-gencounter-tbl-mgmt
359305c 
Fix #870, generic counter table management
@yammajamma yammajamma mentioned this issue Sep 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Caelum
Development

Successfully merging a pull request may close this issue.

Integration Candidate: 2020-09-09 nasa/cFE
2 participants
@jphickey @skliper