Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fsw/mission_inc and fsw/platform_inc (classic build support) #344

Closed
skliper opened this issue Sep 30, 2019 · 3 comments · Fixed by #577 or #635
Closed

Remove fsw/mission_inc and fsw/platform_inc (classic build support) #344

skliper opened this issue Sep 30, 2019 · 3 comments · Fixed by #577 or #635
Assignees
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

Directories are only used by classic build and duplicate defines in sample_defs. Should be removed.

Targeted for 7.0 since it will break classic build (deprecated in 6.7).

@skliper skliper added this to the 7.0.0 milestone Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 313. Created by jhageman on 2019-07-12T15:16:50, last modified: 2019-08-14T14:08:00

@skliper skliper self-assigned this Sep 30, 2019
@skliper skliper removed their assignment Sep 30, 2019
@skliper
Copy link
Contributor Author

skliper commented Nov 1, 2019

@jphickey @acudmore what are our remaining dependencies on these directories? Could one of you list them here?

@jphickey
Copy link
Contributor

jphickey commented Nov 1, 2019

I don't believe CFE has any dependencies on these at all. But sometimes apps directly include them (e.g. SAMPLE_APP or the LAB apps maybe?).

Should be an obvious build failure if there was a dependency though. My recommendation is to take these out, and grep for "mission_inc" or "platform_inc" globally across the code base to verify that nothing directly references it.

If those strings don't exist in any source files and the code builds and runs OK, can be pretty sure that nothing needed them.

@skliper skliper modified the milestones: 7.0.0, 6.8.0 Mar 31, 2020
skliper added a commit to skliper/cFE that referenced this issue Mar 31, 2020
@skliper skliper self-assigned this Apr 21, 2020
astrogeco added a commit that referenced this issue Apr 21, 2020
@astrogeco astrogeco linked a pull request Apr 27, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants