Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE_SB_CreatePipe: Improve message when OS_QueueCreate fails #308

Closed
skliper opened this issue Sep 30, 2019 · 1 comment · Fixed by #452
Closed

CFE_SB_CreatePipe: Improve message when OS_QueueCreate fails #308

skliper opened this issue Sep 30, 2019 · 1 comment · Fixed by #452
Assignees
@CDKnightNASA
Labels
enhancement
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Sep 30, 2019

Currently if OS_QueueCreate fails in CFE_SB_CreatePipe, the message is just "CreatePipeErr:OS_QueueCreate returned %d,app %s". It would be valuable to show the name of the error rather than (or in addition to) the numeric error code. The OS_GetErrorName function may help here if it's available in all of the OSAL implementations.

It may be valuable to provide other details depending on the error. For example, the message in the case of OS_ERR_NAME_TAKEN could indicate the name of the pipe that was requested (and is already in use).
@skliper
Copy link
Contributor Author

skliper commented Sep 30, 2019

Imported from trac issue 277. Created by tflemin1 on 2019-04-09T14:33:04, last modified: 2019-05-23T16:43:54

@skliper skliper self-assigned this Sep 30, 2019
@skliper skliper removed their assignment Sep 30, 2019
@CDKnightNASA CDKnightNASA self-assigned this Nov 27, 2019
CDKnightNASA added a commit to CDKnightNASA/cFE that referenced this issue Jan 6, 2020
@CDKnightNASA
fix for nasa#308
d8de94d
skliper pushed a commit to CDKnightNASA/cFE that referenced this issue Jan 14, 2020
@CDKnightNASA @skliper
Fix nasa#308, Improve SB create pipe error reporting
25e5d9b
@CDKnightNASA CDKnightNASA mentioned this issue Jan 14, 2020
Merged
CDKnightNASA added a commit to CDKnightNASA/cFE that referenced this issue Jan 17, 2020
@CDKnightNASA
fix for nasa#308 -- errors for duplicate pipe name or out of queues
b39d999
CDKnightNASA added a commit to CDKnightNASA/cFE that referenced this issue Jan 22, 2020
@CDKnightNASA
fix for nasa#308 - improved create pipe error reporting with eid and …
7d13f76 
…unit test changes
@astrogeco astrogeco linked a pull request Feb 11, 2020 that will close this issue
Fix #308, Improve SB create pipe error reporting #452
Merged
@astrogeco astrogeco mentioned this issue Feb 12, 2020
Merged
@jphickey jphickey mentioned this issue Mar 12, 2020
Closed
@astrogeco astrogeco added this to the 6.8.0 milestone Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CDKnightNASA CDKnightNASA

Labels
enhancement
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Fix #308, Improve SB create pipe error reporting CDKnightNASA/cFE
3 participants
@CDKnightNASA @skliper @astrogeco