Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert app info structure modification (#1300, #1911), relative to Draco development cycle #2036

Closed
skliper opened this issue Jan 25, 2022 · 0 comments · Fixed by #2037 or #2043
Closed

Comments

@skliper
Copy link
Contributor

skliper commented Jan 25, 2022

Is your feature request related to a problem? Please describe.
CFE_ES_AppInfo_t is public so the change in #1911/#1300 is breaking. Shouldn't have been included in Draco. Makes CS non-portable between Caelum and Draco.

Describe the solution you'd like
Revert.

Describe alternatives you've considered
Could add accessor functions or some sort of abstraction/layer or back-port, but the change really is very low priority. Could be considered in a future major update cycle if there's some actual benefit from the additional structure.

Could make CS adapt also (conditional compilation or whatever), but I don't think it's worth it for this sort of change or carrying that option.

Additional context
Need to decide if we want to reopen #1300 as future work or leave closed.

Requester Info
Jacob Hageman - NASA/GSFC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant