You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not really a bug since it works as intended. Could improve by making 0 an invalid mode, but would break any code that didn't use the CFE_ES_PerfMode_t enum values and/or assumes 0 is valid.
skliper
changed the title
Unsigned Compared Against 0
Unsigned Compared Against 0 always true
Oct 7, 2021
Describe the bug
This greater-than-or-equal-to-zero comparison of an unsigned value is always true. CmdPtr->TriggerMode >= CFE_ES_PERF_TRIGGER_START.
Expected behavior
Fix the if statement.
Code snips
cFE/modules/es/fsw/src/cfe_es_perf.c
Line 168 in 98f78e8
System observed on:
Coverity: https://scan.coverity.com/projects/arielsadamsnasa-cfs-jsf-rules?tab=overview
Reporter Info
Ariel Adams, ASRC Federal
The text was updated successfully, but these errors were encountered: