Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Prototype/implementation mismatch scrub #1474

Closed
skliper opened this issue May 3, 2021 · 0 comments · Fixed by #1551 or #1568
Closed

API Prototype/implementation mismatch scrub #1474

skliper opened this issue May 3, 2021 · 0 comments · Fixed by #1551 or #1568
Assignees
@skliper
Labels
CFS-42 CFS-43 enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented May 3, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
Example from CFE_MSG_Init, CFE_Status_t vs int32:

cFE/modules/msg/fsw/src/cfe_msg_init.c

Line 32 in c8b5e00

int32 CFE_MSG_Init(CFE_MSG_Message_t *MsgPtr, CFE_SB_MsgId_t MsgId, CFE_MSG_Size_t Size)

cFE/modules/core_api/fsw/inc/cfe_msg.h

Line 63 in c8b5e00

CFE_Status_t CFE_MSG_Init(CFE_MSG_Message_t *MsgPtr, CFE_SB_MsgId_t MsgId, CFE_MSG_Size_t Size);

Note numerous others, some noted in TBL.

Describe the solution you'd like
General scrub, prototypes across all the headers should match implementation. Also could remove extern per #1319.

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 7.0.0 milestone May 3, 2021
@skliper skliper mentioned this issue May 3, 2021
Closed
@skliper skliper added the CFS-43 label May 11, 2021
@skliper skliper changed the title CFE_MSG_Init prototype/implementation mismatch Prototype/implementation mismatch scrub May 11, 2021
@zachar1a zachar1a mentioned this issue May 17, 2021
Closed
skliper pushed a commit to skliper/cFE that referenced this issue May 19, 2021
@zachar1a @skliper
Partial nasa#1474, changing return type from int32 to CFE_Status_t
3d61d9d 
Changing the implementation return types to CFE_Status_t
to match the function prototypes.
skliper pushed a commit to skliper/cFE that referenced this issue May 19, 2021
@zachar1a @skliper
Partial nasa#1474, Resolved API function/prototype mismatches
6006b8d
This was referenced May 19, 2021
Merged
Closed
skliper pushed a commit to skliper/cFE that referenced this issue May 19, 2021
@zachar1a @skliper
Partial nasa#1474, changing return type from int32 to CFE_Status_t
7fa73a5 
Changing the implementation return types to CFE_Status_t
to match the function prototypes.
skliper pushed a commit to skliper/cFE that referenced this issue May 19, 2021
@zachar1a @skliper
Partial nasa#1474, Resolved API function/prototype mismatches
9c28130
skliper added a commit to skliper/cFE that referenced this issue May 19, 2021
@skliper
Partial nasa#1474, Updated stubs for function/prototype scrub
7e3effd
@skliper skliper self-assigned this May 21, 2021
@skliper skliper changed the title Prototype/implementation mismatch scrub API Prototype/implementation mismatch scrub May 21, 2021
astrogeco added a commit that referenced this issue May 25, 2021
@astrogeco
Merge pull request #1551 from skliper/fix1474_prototype-scrub
077bd82 
Fix #1474, #1552, Resolve API prototype/implementation discrepancies
@astrogeco astrogeco mentioned this issue May 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
CFS-42 CFS-43 enhancement
Projects
None yet
Milestone
Caelum
1 participant
@skliper