Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove defines for EVS LogMode #1446

Closed
skliper opened this issue Apr 29, 2021 · 2 comments · Fixed by #1553 or #1584
Closed

Remove defines for EVS LogMode #1446

skliper opened this issue Apr 29, 2021 · 2 comments · Fixed by #1553 or #1584

Comments

@skliper
Copy link
Contributor

skliper commented Apr 29, 2021

Is your feature request related to a problem? Please describe.
Enum is defined here:

/**
* @brief Label definitions associated with CFE_EVS_LogMode_Enum_t
*/
enum CFE_EVS_LogMode
{
/**
* @brief Overwrite Log Mode
*/
CFE_EVS_LogMode_OVERWRITE = 0,
/**
* @brief Discard Log Mode
*/
CFE_EVS_LogMode_DISCARD = 1
};

Defines here:

/* EVS Log Modes */
#define CFE_EVS_LOG_OVERWRITE 0
#define CFE_EVS_LOG_DISCARD 1

Describe the solution you'd like
Remove defines, replace any references with the enums.

Describe alternatives you've considered
Boolean for overwrite (although cmd/tlm should be fixed size)

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC

@skliper
Copy link
Contributor Author

skliper commented May 17, 2021

Ping @pepepr08

@pepepr08
Copy link
Contributor

I'll work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants