Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include element that caused write error in event reporting in CFE_EVS_WriteAppDataFileCmd #1432

Closed
skliper opened this issue Apr 28, 2021 · 4 comments · Fixed by #2326
Closed

Comments

@skliper
Copy link
Contributor

skliper commented Apr 28, 2021

Is your feature request related to a problem? Please describe.
Element that caused error not included in event, so not obvious how much of the write was completed

EVS_SendEvent(CFE_EVS_ERR_WRDATFILE_EID, CFE_EVS_EventType_ERROR,
"Write App Data Command Error: OS_write = 0x%08X, filename = %s",
(unsigned int)BytesWritten, LocalName);

Describe the solution you'd like
Add the element number

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC

@thnkslprpt
Copy link
Contributor

@skliper Were you thinking something like this?
image
or
image

@skliper
Copy link
Contributor Author

skliper commented May 3, 2023

@thnkslprpt I don't have strong feelings, but maybe "Write App Data Command Error: At entry %d of %d, OS_write..."?

@thnkslprpt
Copy link
Contributor

@skliper - how would you get the second value (of)?

Isn't the total number of entries that was supposed to be written only known after the for loop ends? Or do you mean to just use CFE_PLATFORM_ES_MAX_APPLICATIONS?

@skliper
Copy link
Contributor Author

skliper commented May 4, 2023

@thnkslprpt - very good point! Stick w/ just EntryCount.

dzbaker added a commit that referenced this issue Aug 2, 2024
…e-error-event

Fix #1432, Add element to write error event in CFE_EVS_WriteAppDataFileCmd()
@dzbaker dzbaker closed this as completed in 5b53ca2 Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants