Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 128 increase test coverage #135

Merged
merged 10 commits into from
Jun 27, 2024

Conversation

danielfromearth
Copy link
Collaborator

@danielfromearth danielfromearth commented Jun 24, 2024

GitHub Issue: #128

Description

This change adds a mocked test of invoking batchee with the harmony adapter. It also adds a test of using batchee's grouping of TEMPO file names at the command line.

Local test steps

Added tests and passed.

Overview of integration done

Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.

PR Acceptance Checklist

  • Unit tests added/updated and passing.
  • Integration testing
  • CHANGELOG.md updated
  • [n/a] Documentation updated (if needed).

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.21%. Comparing base (3104b8d) to head (f5e9d46).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #135       +/-   ##
============================================
+ Coverage    14.92%   84.21%   +69.28%     
============================================
  Files            4        4               
  Lines          134      133        -1     
============================================
+ Hits            20      112       +92     
+ Misses         114       21       -93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielfromearth danielfromearth self-assigned this Jun 24, 2024
@danielfromearth danielfromearth merged commit 39698ec into develop Jun 27, 2024
4 checks passed
@danielfromearth danielfromearth deleted the feature/issue1-28-increase-test-coverage branch June 27, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase continuous integration/unit test coverage
3 participants