Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue X-RateLimit-Limit, X-RateLimit-Remaining headers weren't able to be accessed by browsers #73

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

kgmyatthu
Copy link
Contributor

@kgmyatthu kgmyatthu commented May 7, 2021

Fix the issue X-RateLimit-Limit, X-RateLimit-Remaining headers weren't able to be accessed by browsers

This PR attempts to fix the issue we have with accessing X-RateLimit-Remaining headers in apod-api which described here #64

I think it is also critical that API consumer can monitor their API limits autonomously in applications. Since Expose Header is not set and thus almost every trusted modern browsers are preventing API consumers from accessing the X-RateLimit-Limit, X-RateLimit-Remaining headers.

@kgmyatthu kgmyatthu changed the title added X-RateLimit-Limit, X-RateLimit-Remaining headers to Access-Control-Expose-Headers configuration Fix the issue X-RateLimit-Limit, X-RateLimit-Remaining headers weren't able to be accessed by browsers May 8, 2021
@MilesCrabbe MilesCrabbe merged commit e69d56d into nasa:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants