Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared workflow scripts need updates for node.js version #429

Closed
chillfig opened this issue May 1, 2024 · 0 comments · Fixed by #430
Closed

Shared workflow scripts need updates for node.js version #429

chillfig opened this issue May 1, 2024 · 0 comments · Fixed by #430
Assignees
@chillfig
Labels
continuous-integration

Comments

@chillfig
Copy link
Contributor

chillfig commented May 1, 2024

Describe the bug
actions/checkout@v3 in https://github.com/nasa/PSP/blob/main/.github/workflows/icbundle.yml uses node.js version 16, which is now deprecated.

To Reproduce
Manual inspection

Expected behavior
No warnings in github workflows mentioning deprecated node.js versions

Code snips

PSP/.github/workflows/icbundle.yml

Line 22 in 70be39d

uses: actions/checkout@v3

System observed on:

  • OS: Ubuntu 20.04

Additional context
Copy of concern in nasa/cFS#742
This modified workflow may be obsolete/never used? https://github.com/nasa/PSP/actions/workflows/icbundle.yml

Reporter Info
Justin Figueroa, Vantage Systems
@chillfig chillfig added CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) continuous-integration labels May 1, 2024
@chillfig chillfig self-assigned this May 1, 2024
@chillfig chillfig removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label May 1, 2024
@chillfig chillfig mentioned this issue May 1, 2024
Merged
2 tasks
dzbaker added a commit that referenced this issue May 6, 2024
@dzbaker
Merge pull request #430 from chillfig:node20
14e44dd 
Fix #429, Adds node20 compatible github actions
@dzbaker dzbaker mentioned this issue May 6, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chillfig chillfig

Labels
continuous-integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #429, Adds node20 compatible github actions chillfig/PSP
1 participant
@chillfig