-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert PR #52 #77
Comments
@dzbaker - what were the bugs? Documented anywhere? |
The change was causing issues with functional testing because the number of characters used (2) in the following calculation is incorrect: The value should actually be 3 because there is a space in between each byte displayed. The end result is that the message gets truncated and the memory location dumped gets corrupted/lost. Because we are wrapping up the build/past the cut off, and the change is relatively minor, we are trying to punt this to the next build. Good catch on the documentation - we need to clean up the PR/Issue to make sure we don't accidentally drop this next round. |
Checklist (Please check before submitting)
Describe the bug
The changes included in PR #52 introduce bugs. We will revert the PR for this release, then revisit it following release.
Reporter Info
Dylan Z. Baker - NASA/GSFC
The text was updated successfully, but these errors were encountered: