Fix #8, Remove unnecessary characters from memory dump event #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thnkslprpt
force-pushed
the
fix-8-remove-unnecessary-characters-in-dump-event
branch
2 times, most recently
from
d96f62b
to
3746982
Compare
thnkslprpt
force-pushed
the
fix-8-remove-unnecessary-characters-in-dump-event
branch
from
3746982
to
e948cdd
Compare
havencarlson
approved these changes
May 25, 2023
dzbaker
added a commit
that referenced
this pull request
Jul 6, 2023
dzbaker
added a commit
to dzbaker/MM
that referenced
this pull request
Jul 11, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
0xand trailing space around each byte from the dump event message.Testing performed
Build & Run + Unit Tests.
Expected behavior changes
Increases the number of bytes that can be dumped in the event message string dramatically (by around double, depending on the value that is set for
CFE_MISSION_EVS_MAX_MESSAGE_LENGTH).Contributor Info
Avi Weiss @thnkslprpt