You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I reviewed the README file to see if the feature is in the major future work.
I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.
Is your feature request related to a problem? Please describe.
The following identifiers used in LC do not correctly follow the naming conventions for CFE/CFS symbols:
LC_SET_AP_PERMOFF_CC: should be LC_SET_AP_PERM_OFF_CC, because the CamelCase version is LC_SetAPPermOff_t, thus "Perm" and "Off" are separate words.
LC_ACTION_NOT_USED: should be LC_APSTATE_ACTION_NOT_USED, because its used as an enum and the other labels all start with LC_APSTATE prefix
LC_WATCH_NOT_USED: should be LC_DATA_WATCH_NOT_USED, for the same reason as LC_ACTION above.
LC_NO_OPER: should be LC_OPER_NONE, same reason
LC_NO_BITMASK: should be LC_BITMASK_NONE
Describe the solution you'd like
Rename these symbols for consistency.
Additional context
These name mismatches become relevant when using generated header files.
Requester Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered:
Checklist (Please check before submitting)
Is your feature request related to a problem? Please describe.
The following identifiers used in LC do not correctly follow the naming conventions for CFE/CFS symbols:
LC_SET_AP_PERMOFF_CC
: should beLC_SET_AP_PERM_OFF_CC
, because the CamelCase version isLC_SetAPPermOff_t
, thus "Perm" and "Off" are separate words.LC_ACTION_NOT_USED
: should beLC_APSTATE_ACTION_NOT_USED
, because its used as an enum and the other labels all start withLC_APSTATE
prefixLC_WATCH_NOT_USED
: should beLC_DATA_WATCH_NOT_USED
, for the same reason as LC_ACTION above.LC_NO_OPER
: should beLC_OPER_NONE
, same reasonLC_NO_BITMASK
: should beLC_BITMASK_NONE
Describe the solution you'd like
Rename these symbols for consistency.
Additional context
These name mismatches become relevant when using generated header files.
Requester Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: