Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct naming convention inconsistencies #70

Closed
3 tasks done
jphickey opened this issue Feb 13, 2023 · 0 comments · Fixed by #74
Closed
3 tasks done

Correct naming convention inconsistencies #70

jphickey opened this issue Feb 13, 2023 · 0 comments · Fixed by #74

Comments

@jphickey
Copy link
Contributor

jphickey commented Feb 13, 2023

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
The following identifiers used in LC do not correctly follow the naming conventions for CFE/CFS symbols:

  • LC_SET_AP_PERMOFF_CC: should be LC_SET_AP_PERM_OFF_CC, because the CamelCase version is LC_SetAPPermOff_t, thus "Perm" and "Off" are separate words.
  • LC_ACTION_NOT_USED: should be LC_APSTATE_ACTION_NOT_USED, because its used as an enum and the other labels all start with LC_APSTATE prefix
  • LC_WATCH_NOT_USED: should be LC_DATA_WATCH_NOT_USED, for the same reason as LC_ACTION above.
  • LC_NO_OPER: should be LC_OPER_NONE, same reason
  • LC_NO_BITMASK: should be LC_BITMASK_NONE

Describe the solution you'd like
Rename these symbols for consistency.

Additional context
These name mismatches become relevant when using generated header files.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants