Fix #77, Combine consecutive, mutually-exclusive status checks #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thnkslprpt
force-pushed
the
fix-77-combine-consecutive-mutually-exclusive-status-checks
branch
from
49f95bc
to
43a17cf
Compare
thnkslprpt
deleted the
fix-77-combine-consecutive-mutually-exclusive-status-checks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
Fixes #77
Combined 2 consecutive, mutually exclusive status checks (no need to evaluate twice).
Also moved failure the event down to what I believe is a clearer pattern (and more common in cFS) of the successful series of operations together and failure events (in the
elseblocks) all together cascading backwards below.Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.
Expected behavior changes
No change to logic. No test changes required. Coverage still at 100%.
Contributor Info
Avi Weiss @thnkslprpt