Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split "platform_cfg" into external and internal components #84

Closed
3 tasks done
jphickey opened this issue Mar 23, 2023 · 0 comments · Fixed by #87
Closed
3 tasks done

Split "platform_cfg" into external and internal components #84

jphickey opened this issue Mar 23, 2023 · 0 comments · Fixed by #87

Comments

@jphickey
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
Currently, all configurable items for the app are contained in a single hs_platform_cfg.h header file. This contains macro definitions that affect both the internal operation of the application (such as operational limits) as well as the external interface in CMD/TLM and table files.

Describe the solution you'd like
Split this header into two components, one that contains only public items (i.e. those that affect CMD/TLM/Table definitions) and one that contains private/internal items that are only used within the local application code and do not affect the interface.

Additional context
Mainly a scoping concern, separate files for separate scopes. These files could also be generated in the future, but scope still needs to be consistent.

Requester Info
Joseph Hickey, Vantage Systems, Inc.

jphickey added a commit to jphickey/HS that referenced this issue Apr 6, 2023
Move configuration include files to a separate "config" subdirectory,
and use the "generate_config_includefile" cmake function to select the
one to use and create a wrapper.

This makes it easier to override the file and/or use a generated file in
place of the distribution/default copy.
jphickey added a commit to jphickey/HS that referenced this issue Apr 6, 2023
Move configuration include files to a separate "config" subdirectory,
and use the "generate_config_includefile" cmake function to select the
one to use and create a wrapper.

This makes it easier to override the file and/or use a generated file in
place of the distribution/default copy.
jphickey added a commit to jphickey/HS that referenced this issue Apr 6, 2023
Move configuration include files to a separate "config" subdirectory,
and use the "generate_config_includefile" cmake function to select the
one to use and create a wrapper.

This makes it easier to override the file and/or use a generated file in
place of the distribution/default copy.
jphickey added a commit to jphickey/HS that referenced this issue Apr 6, 2023
Move configuration include files to a separate "config" subdirectory,
and use the "generate_config_includefile" cmake function to select the
one to use and create a wrapper.

This makes it easier to override the file and/or use a generated file in
place of the distribution/default copy.
dzbaker added a commit that referenced this issue Apr 6, 2023
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants