Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #118, Standardize command responses #122

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Jul 6, 2024

Checklist

Describe the contribution

As per the discussion in the issue, most of the first list were already fixed, and the 2nd list I have left alone to maintain consistency - of the 8 'partial success' events that increment the ChildCmdWarnCounter, all are INFORMATION type, except FM_GET_FILE_INFO_OPEN_ERR_EID which is of ERROR type (perhaps need a separate issue to align this).

Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).

Expected behavior changes
As above.

System(s) tested on
Debian GNU/Linux 11 (bullseye)
Current main branch of cFS bundle.

Contributor Info
Avi Weiss   @thnkslprpt

@pepepr08 pepepr08 self-requested a review October 24, 2024 18:22
@dzbaker
Copy link
Contributor

dzbaker commented Oct 24, 2024

@thnkslprpt Thank you for the contribution! Would you be able to resolve the merge conflicts?

@thnkslprpt thnkslprpt force-pushed the fix-118-standardize-command-responses branch from 0211fed to 433f557 Compare October 24, 2024 19:12
@thnkslprpt
Copy link
Contributor Author

@thnkslprpt Thank you for the contribution! Would you be able to resolve the merge conflicts?

@dzbaker updated.

@dzbaker dzbaker merged commit ca7faf8 into nasa:main Oct 24, 2024
16 checks passed
@thnkslprpt thnkslprpt deleted the fix-118-standardize-command-responses branch October 25, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardization of Command Responses
3 participants