You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I reviewed the README file to see if the feature is in the major future work.
I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.
Is your feature request related to a problem? Please describe.
CFE has an established pattern for message dispatch routines in that:
It returns a CFE_Status_t (standard return value)
It accepts a single argument which is a const pointer to the message, of the actual/unique message type (e.g. CFE_ES_NoopCmd_t, etc).
FM does not follow this pattern, its message processor functions return bool and they accept the generic CFE SB message buffer rather than the specific message type.
Describe the solution you'd like
Make FM follow the CFE pattern
Additional context
This makes every command handler prototype unique, so they cannot be inadvertently interchanged without a compile error (this is a good thing).
Requester Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered:
Checklist (Please check before submitting)
Is your feature request related to a problem? Please describe.
CFE has an established pattern for message dispatch routines in that:
CFE_Status_t
(standard return value)CFE_ES_NoopCmd_t
, etc).FM does not follow this pattern, its message processor functions return
bool
and they accept the generic CFE SB message buffer rather than the specific message type.Describe the solution you'd like
Make FM follow the CFE pattern
Additional context
This makes every command handler prototype unique, so they cannot be inadvertently interchanged without a compile error (this is a good thing).
Requester Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: